-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split onnx parse tests into separate files #2550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2550 +/- ##
===========================================
- Coverage 91.39% 91.39% -0.01%
===========================================
Files 454 454
Lines 17193 17191 -2
===========================================
- Hits 15713 15711 -2
Misses 1480 1480 ☔ View full report in Codecov by Sentry. |
This build is OK for merge ✅ |
🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it, with some suggested cosmetic changes, below:
- Please spell-check the PR title.
- Please update the copyright timestamps. Not just for the new files.
LGTM. Fix your CI errors (format/tidy) but looks good |
So this puts the parse tests under
test/onnx/parse
. I plan to split the verify tests as well and put them into thetest/onnx/verify
directory. There is a cpp file for each onnx file(except the rnn tests which I am not splitting).In the future, we could also move the onnx files to the
test/onnx/models
directory, but for now I just split the tests.