Use mlir_mode::fast for dot operations on Navi and reduce k threshold to 1024 #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like this is missing the k<1024 change. |
pfultz2
reviewed
Jan 9, 2024
| find_mlir_standalone_convolution_op{get_mode("convolution", mlir_mode::int8)}, | ||
| find_mlir_standalone_dot_op{get_mode("dot", mlir_mode::none)}); | ||
| find_mlir_standalone_convolution_op{get_mode("convolution", mlir_mode::fast)}, | ||
| find_mlir_standalone_dot_op{is_navi ? mlir_mode::fast : get_mode("dot", mlir_mode::none)}); |
There was a problem hiding this comment.
This should probably be get_mode("dot", mode) so we use MLIR for dot fusions when using the MIGRAPHX_ENABLE_EXTRA_MLIR setting.
There was a problem hiding this comment.
Sorry thats not the case. This is standalone.
pfultz2
approved these changes
Jan 10, 2024
|
Can this be targeted to develop and then cherry picked into the release branch? |
|
This can be closed. We won't be using this technique |
|
There will not be a need to target this against rocm-rel-6.0. If you have other uses in 6.1 then go for it but a new PR might be easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.