Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Einsum operator #2772

Merged
merged 42 commits into from
May 29, 2024
Merged

Add support for the Einsum operator #2772

merged 42 commits into from
May 29, 2024

Conversation

mirza-halilcevic
Copy link
Collaborator

@mirza-halilcevic mirza-halilcevic commented Feb 14, 2024

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Feb 14, 2024

Test Batch Rate new
7140ae
Rate old
dc028d
Diff Compare
torchvision-resnet50 64 1,713.92 1,489.70 15.05% 🔆
torchvision-resnet50_fp16 64 3,810.84 1,346.10 183.10% 🔆
torchvision-densenet121 32 1,453.97 1,440.50 0.94%
torchvision-densenet121_fp16 32 2,435.42 2,416.72 0.77%
torchvision-inceptionv3 32 883.32 881.27 0.23%
torchvision-inceptionv3_fp16 32 1,412.36 1,406.66 0.41%
cadene-inceptionv4 16 407.47 404.25 0.80%
cadene-resnext64x4 16 413.99 410.23 0.92%
slim-mobilenet 64 3,823.89 3,794.28 0.78%
slim-nasnetalarge 64 97.06 94.95 2.22%
slim-resnet50v2 64 1,652.06 1,620.87 1.92%
bert-mrpc-onnx 8 589.65 591.10 -0.25%
bert-mrpc-tf 1 289.94 289.30 0.22%
pytorch-examples-wlang-gru 1 333.82 378.53 -11.81% 🔴
pytorch-examples-wlang-lstm 1 303.50 266.28 13.98% 🔆
torchvision-resnet50_1 1 453.79 369.37 22.86% 🔆
cadene-dpn92_1 1 245.35 233.66 5.00% 🔆
cadene-resnext101_1 1 189.30 189.16 0.07%
onnx-taau-downsample 1 204.05 183.13 11.43% 🔆
dlrm-criteoterabyte 1 22.29 21.99 1.38%
dlrm-criteoterabyte_fp16 1 41.63 41.43 0.47%
agentmodel 1 6,211.60 6,337.70 -1.99%
unet_fp16 2 33.74 33.63 0.33%
resnet50v1_fp16 1 557.63 521.53 6.92% 🔆
resnet50v1_int8 1 463.51 452.53 2.43%
bert_base_cased_fp16 64 620.97 620.67 0.05%
bert_large_uncased_fp16 32 193.84 193.85 -0.01%
bert_large_fp16 1 103.92 103.88 0.04%
distilgpt2_fp16 16 1,187.47 1,187.83 -0.03%
yolov5s 1 298.21 297.39 0.27%
tinyllama 1 23.34 23.34 0.02%
vicuna-fastchat 1 132.42 132.19 0.17%
whisper-tiny-encoder 1 240.97 240.52 0.19%
whisper-tiny-decoder 1 245.84 245.42 0.17%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Feb 14, 2024


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 98.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.92%. Comparing base (dc028dd) to head (7140ae2).
Report is 148 commits behind head on develop.

Files Patch % Lines
src/onnx/parse_einsum.cpp 98.91% 3 Missing ⚠️
src/lexing.cpp 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2772      +/-   ##
===========================================
+ Coverage    91.82%   91.92%   +0.10%     
===========================================
  Files          486      489       +3     
  Lines        18993    19275     +282     
===========================================
+ Hits         17440    17719     +279     
- Misses        1553     1556       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirza-halilcevic mirza-halilcevic marked this pull request as ready for review March 11, 2024 14:38
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
@causten causten requested a review from CharlieL7 March 11, 2024 18:36
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
src/onnx/parse_einsum.cpp Outdated Show resolved Hide resolved
@causten
Copy link
Collaborator

causten commented May 15, 2024

Windows CI is failing. Seems like...
src\onnx\parse_einsum.cpp:516:21: error: use of undeclared identifier 'ssize_t'

@mirza-halilcevic
Copy link
Collaborator Author

mirza-halilcevic commented May 16, 2024

Windows CI is failing. Seems like... src\onnx\parse_einsum.cpp:516:21: error: use of undeclared identifier 'ssize_t'

I replaced ssize_t with int64_t. Seems like it's still failing for some other reason. I don't have access to the logs though.

@causten
Copy link
Collaborator

causten commented May 29, 2024

I see the extended Jenkins tests run but they are not reflecting on this PR list. They all passed so I'm merging

@causten causten merged commit 30cab64 into develop May 29, 2024
21 of 22 checks passed
@causten causten deleted the einsum_support branch May 29, 2024 17:46
lajagapp pushed a commit to lajagapp/AMDMIGraphX that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Einsum operator is unsupported
7 participants