Parse ONNX Expand to broadcast_with_dims
#2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into dot_broadcast
… into dot_broadcast
…GraphX into dot_broadcast
… into dot_broadcast
… into dot_broadcast
CharlieL7
requested review from
turneram
and removed request for
pfultz2 and
turneram
|
What's the reason this was created as a separate op instead of extra functionality for the |
bpickrel
suggested changes
Mar 29, 2024
| * input_tensor shape: lens = {2, 3}, strides = {3, 1} | ||
| * dims = [4, 1, 3] | ||
| * output shape: lens = {4, 2, 3}, strides = {0, 3, 1} | ||
| */ |
There was a problem hiding this comment.
I like this example make this one of the tests so we can have a 1:1 with expected behavior
TedThemistokleous
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
@CharlieL7 overall looks good. Move so change the one test with your example you mention in the code. You already have 100% coverage so more just change the test to mirror the docstring.
I've kicked off CI for you on this and the previous runs have been passing/without issue.
very messy that way, this way is cleaner |
TedThemistokleous
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dot_broadcastoperator #2629broadcast_with_dimsthat broadcasts a shape with the dimensions given as the second input.Expandwhen the second input is not constant.