Mlir disable specific ops #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umangyadav
reviewed
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2882 +/- ##
========================================
Coverage 91.82% 91.82%
========================================
Files 477 477
Lines 18112 18112
========================================
Hits 16631 16631
Misses 1481 1481 ☔ View full report in Codecov by Sentry. |
umangyadav
previously approved these changes
Mar 12, 2024
umangyadav
reviewed
Mar 12, 2024
| { | ||
| if(s.empty()) | ||
| return false; | ||
| return contains({'!', '~'}, s[0]); |
There was a problem hiding this comment.
you don't necessarily need to use contains s[0] == '!' or s[0] == '~' should suffice.
umangyadav
reviewed
Mar 12, 2024
|
We should update the documentation showing how to disable the specific ops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific ops can be disabled using the
!or~prefix to disable it.