Update _toc.yml.in #2884
Merged
Update _toc.yml.in #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2884 +/- ##
========================================
Coverage 91.84% 91.84%
========================================
Files 478 478
Lines 18179 18179
========================================
Hits 16696 16696
Misses 1483 1483 ☔ View full report in Codecov by Sentry. |
pfultz2
reviewed
Mar 13, 2024
docs/sphinx/_toc.yml.in
Outdated
| - entries: | ||
| - file: reference/driver-options | ||
|
|
||
| - caption: Tutorial |
There was a problem hiding this comment.
dev/contributing documentation should not go under Tutorial heading. This dev/contributing is not for users of migraphx so it should not go under a tutorial heading.
pfultz2
reviewed
Mar 13, 2024
| entries: | ||
| - file: reference/cpp | ||
| - file: reference/py | ||
|
|
||
| - caption: Command-line tool | ||
| entries: | ||
| - file: migraphx-driver |
There was a problem hiding this comment.
This should go under the reference section. It shouldn't be a seperate section.
There was a problem hiding this comment.
@pfultz2 https://advanced-micro-devices-demo--2884.com.readthedocs.build/projects/AMDMIGraphX/en/2884/ Let me know if it looks good to you now.
randyh62
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.