Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rocgdb in the dockerfile #2893

Merged
merged 9 commits into from
May 10, 2024
Merged

Enable rocgdb in the dockerfile #2893

merged 9 commits into from
May 10, 2024

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Mar 18, 2024

rocgdb is not supported on 22.04. This works around the issue by installing the older python version used on ubuntu 20.04(the newer python is still install in the dockerfile).

@pfultz2 pfultz2 requested a review from causten as a code owner March 18, 2024 15:48
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (70c338b) to head (9d0be0f).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2893   +/-   ##
========================================
  Coverage    91.78%   91.78%           
========================================
  Files          485      486    +1     
  Lines        18856    18864    +8     
========================================
+ Hits         17307    17315    +8     
  Misses        1549     1549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Mar 18, 2024

Test Batch Rate new
9d0be0
Rate old
70c338
Diff Compare
torchvision-resnet50 64 2,789.19 2,790.00 -0.03%
torchvision-resnet50_fp16 64 6,201.43 6,199.57 0.03%
torchvision-densenet121 32 2,091.79 2,084.35 0.36%
torchvision-densenet121_fp16 32 3,613.46 3,605.22 0.23%
torchvision-inceptionv3 32 1,598.40 1,601.61 -0.20%
torchvision-inceptionv3_fp16 32 2,555.28 2,556.65 -0.05%
cadene-inceptionv4 16 716.18 716.23 -0.01%
cadene-resnext64x4 16 678.03 677.92 0.02%
slim-mobilenet 64 5,811.58 5,811.31 0.00%
slim-nasnetalarge 64 154.22 154.23 -0.01%
slim-resnet50v2 64 2,577.59 2,578.74 -0.04%
bert-mrpc-onnx 8 968.80 969.17 -0.04%
bert-mrpc-tf 1 445.87 410.10 8.72% 🔆
pytorch-examples-wlang-gru 1 400.02 392.78 1.84%
pytorch-examples-wlang-lstm 1 379.58 370.94 2.33%
torchvision-resnet50_1 1 598.97 606.52 -1.24%
cadene-dpn92_1 1 390.21 383.07 1.87%
cadene-resnext101_1 1 324.98 324.89 0.03%
onnx-taau-downsample 1 307.40 306.95 0.15%
dlrm-criteoterabyte 1 28.53 28.54 -0.01%
dlrm-criteoterabyte_fp16 1 47.20 47.10 0.21%
agentmodel 1 7,305.56 7,467.31 -2.17%
unet_fp16 2 57.61 57.50 0.19%
resnet50v1_fp16 1 881.14 878.12 0.34%
resnet50v1_int8 1 794.54 791.31 0.41%
bert_base_cased_fp16 64 1,021.50 1,021.83 -0.03%
bert_large_uncased_fp16 32 298.99 298.84 0.05%
bert_large_fp16 1 156.26 158.53 -1.44%
distilgpt2_fp16 16 1,830.49 1,834.50 -0.22%
yolov5s 1 475.58 470.88 1.00%
tinyllama 1 33.00 33.01 -0.03%
vicuna-fastchat 1 158.14 157.97 0.11%
whisper-tiny-encoder 1 348.69 352.77 -1.16%
whisper-tiny-decoder 1 401.66 399.88 0.44%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Mar 18, 2024


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Comment on lines +18 to +19
# rocgdb doesn't work on 22.04, workaround by installing the older python packages that are in 20.04
RUN add-apt-repository -y ppa:deadsnakes/ppa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the connection between rocgdb and python version ?
rocgdb uses python3.8 internally ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it uses libpython3.8 directly which is not available on ubuntu 22.04.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to install "software-properties-common" before running add-apt-repository

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the missing package.

Comment on lines +18 to +19
# rocgdb doesn't work on 22.04, workaround by installing the older python packages that are in 20.04
RUN add-apt-repository -y ppa:deadsnakes/ppa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to install "software-properties-common" before running add-apt-repository

@causten causten merged commit cc7c280 into develop May 10, 2024
19 checks passed
@causten causten deleted the rocgdb-22.04 branch May 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants