-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable rocgdb in the dockerfile #2893
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2893 +/- ##
========================================
Coverage 91.78% 91.78%
========================================
Files 485 486 +1
Lines 18856 18864 +8
========================================
+ Hits 17307 17315 +8
Misses 1549 1549 ☔ View full report in Codecov by Sentry. |
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
# rocgdb doesn't work on 22.04, workaround by installing the older python packages that are in 20.04 | ||
RUN add-apt-repository -y ppa:deadsnakes/ppa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the connection between rocgdb and python version ?
rocgdb uses python3.8 internally ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it uses libpython3.8 directly which is not available on ubuntu 22.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to install "software-properties-common" before running add-apt-repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the missing package.
# rocgdb doesn't work on 22.04, workaround by installing the older python packages that are in 20.04 | ||
RUN add-apt-repository -y ppa:deadsnakes/ppa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to install "software-properties-common" before running add-apt-repository
rocgdb is not supported on 22.04. This works around the issue by installing the older python version used on ubuntu 20.04(the newer python is still install in the dockerfile).