-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip FP8 dot/gemm for MLIR and offload them to rocBLAS #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umangyadav
requested review from
pfultz2,
shivadbhavsar,
kahmed10 and
TedThemistokleous
March 25, 2024 14:59
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2924 +/- ##
========================================
Coverage 91.83% 91.83%
========================================
Files 479 479
Lines 18340 18340
========================================
Hits 16842 16842
Misses 1498 1498 ☔ View full report in Codecov by Sentry. |
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
TedThemistokleous
approved these changes
Mar 25, 2024
TedThemistokleous
added
bugfix
Fixes a bug found in the code.
simple
small or simple changes
labels
Mar 25, 2024
shivadbhavsar
approved these changes
Mar 25, 2024
umangyadav
added a commit
that referenced
this pull request
Mar 25, 2024
* add skip for FP8 dot/gemm inside MLIR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIGraphX has verify tests where it tests
FP8 * FP8 = FP8
case.rocBLAS has support for it but not the MLIR. rocBLAS internally converts the output of the GEMM to fp8.
FP8 * FP8 = FP8
case is probably unlikely to happen for the gemm/dot operations. It should mostly befp8 * fp8 = fp32
.FP8 tests are run on MI300 hardware and therefore Jenkins has not seen any failures but 1416489 broke unit-tests for FP8 * FP8 = FP8 case on MI300 because with that change all the gemms with
k<=1028
are now being offloaded to MLIR.