-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use number of specified thread for the compilation #2978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @causten this may be related to that issue we saw last week with par_for falling especially that stack dump we saw in within simple_par_for in gdb.
We shouldn't do this. The |
Done |
Ah, that makes better sense and good catch. Didn't really think about the parallel STL case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2978 +/- ##
========================================
Coverage 91.86% 91.86%
========================================
Files 484 484
Lines 18609 18609
========================================
Hits 17095 17095
Misses 1514 1514 ☔ View full report in Codecov by Sentry. |
Currently
MIGRAPHX_GPU_COMPILE_PARALLEL
has no effect becausepar_for.hpp
is not passingmin_grain
param. This PR fixes that.