-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Model Zoo testing support #2990
Conversation
A very WIP version. Uses ResNet50 and Imagenet only.
# THE SOFTWARE. | ||
# | ||
##################################################################################### | ||
-f https://repo.radeon.com/rocm/manylinux/rocm-rel-6.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you bump the version for this?
tools/model_zoo/onnx_zoo/README.md
Outdated
|
||
## Getting the repository | ||
|
||
*Important: make sure to enable git-lfs* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Important: make sure to enable git-lfs* | |
> [!IMPORTANT] | |
> Make sure to enable git-lfs. |
tools/model_zoo/onnx_zoo/README.md
Outdated
|
||
## Running the tests | ||
|
||
*Important: the argument must point to a folder, not a file* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Important: the argument must point to a folder, not a file* | |
> [!IMPORTANT] | |
> The argument must point to a folder, not a file. |
./test_models.sh generated/ | ||
``` | ||
|
||
Note: `generated` is the default output folder, make sure to match `--output-folder-prefix` name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: `generated` is the default output folder, make sure to match `--output-folder-prefix` name | |
> [!NOTE] | |
> `generated` is the default output folder, make sure to match `--output-folder-prefix` name. |
Max number of sum-samples generated for decoder models. Use 0 to ignore it. (Only for decoder models) | ||
``` | ||
|
||
Note: Some models require permission to access, use `huggingface-cli login` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Some models require permission to access, use `huggingface-cli login` | |
> [!NOTE] | |
> Some models require permission to access, use `huggingface-cli login`. |
|
||
## Adding more datasets | ||
|
||
The 3 most common usecase are handled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 most common usecase are handled: | |
The 3 most common use cases are handled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From review side, looks good. Would need someone to test and verify it works. @causten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working without any errors. By default, the numpy 2.0 is there but it requires numpy 1.24.1
Oh right, it was released not long ago. |
Co-authored-by: Chris Austen <[email protected]>
(cherry picked from commit 497c277)
This change adds 2 "Model Zoo" to test: