Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expand parsing #3027

Merged
merged 5 commits into from
May 6, 2024
Merged

Fix expand parsing #3027

merged 5 commits into from
May 6, 2024

Conversation

CharlieL7
Copy link
Collaborator

  • Fix an bug with ONNX Expand parsing of a dynamic input[0].

@CharlieL7 CharlieL7 self-assigned this May 1, 2024
@migraphx-bot
Copy link
Collaborator

migraphx-bot commented May 1, 2024

Test Batch Rate new
83b548
Rate old
282199
Diff Compare
torchvision-resnet50 64 2,820.71 2,815.48 0.19%
torchvision-resnet50_fp16 64 6,405.71 6,399.55 0.10%
torchvision-densenet121 32 2,088.15 2,105.12 -0.81%
torchvision-densenet121_fp16 32 3,694.45 3,695.12 -0.02%
torchvision-inceptionv3 32 1,605.85 1,605.11 0.05%
torchvision-inceptionv3_fp16 32 2,552.38 2,551.73 0.03%
cadene-inceptionv4 16 717.98 717.63 0.05%
cadene-resnext64x4 16 680.43 680.15 0.04%
slim-mobilenet 64 5,935.21 5,945.58 -0.17%
slim-nasnetalarge 64 154.03 154.01 0.01%
slim-resnet50v2 64 2,586.59 2,587.50 -0.04%
bert-mrpc-onnx 8 920.62 921.18 -0.06%
bert-mrpc-tf 1 395.99 397.13 -0.29%
pytorch-examples-wlang-gru 1 393.38 391.06 0.59%
pytorch-examples-wlang-lstm 1 369.58 374.28 -1.26%
torchvision-resnet50_1 1 605.22 601.79 0.57%
cadene-dpn92_1 1 390.45 387.13 0.86%
cadene-resnext101_1 1 333.19 331.86 0.40%
onnx-taau-downsample 1 307.30 306.45 0.28%
dlrm-criteoterabyte 1 28.86 28.85 0.05%
dlrm-criteoterabyte_fp16 1 48.27 48.32 -0.09%
agentmodel 1 7,390.44 7,309.46 1.11%
unet_fp16 2 57.53 57.49 0.06%
resnet50v1_fp16 1 906.25 923.36 -1.85%
resnet50v1_int8 1 795.40 790.05 0.68%
bert_base_cased_fp16 64 1,033.68 1,033.89 -0.02%
bert_large_uncased_fp16 32 300.41 300.27 0.05%
bert_large_fp16 1 159.94 159.97 -0.02%
distilgpt2_fp16 16 1,856.53 1,858.79 -0.12%
yolov5s 1 467.31 468.06 -0.16%
tinyllama 1 32.98 32.96 0.06%
vicuna-fastchat 1 158.19 157.57 0.39%
whisper-tiny-encoder 1 352.11 348.16 1.13%
whisper-tiny-decoder 1 396.42 396.77 -0.09%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@CharlieL7 CharlieL7 marked this pull request as ready for review May 2, 2024 15:39
@CharlieL7 CharlieL7 requested a review from causten as a code owner May 2, 2024 15:39
@CharlieL7 CharlieL7 added bugfix Fixes a bug found in the code. simple small or simple changes labels May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (e329667) to head (83b5488).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3027   +/-   ##
========================================
  Coverage    91.76%   91.76%           
========================================
  Files          485      485           
  Lines        18774    18777    +3     
========================================
+ Hits         17228    17231    +3     
  Misses        1546     1546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten merged commit 5306a70 into develop May 6, 2024
40 of 44 checks passed
@causten causten deleted the parse_expand_fix branch May 6, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code. simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants