Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license check on push too #3044

Merged
merged 1 commit into from
May 7, 2024
Merged

license check on push too #3044

merged 1 commit into from
May 7, 2024

Conversation

causten
Copy link
Collaborator

@causten causten commented May 6, 2024

Turns out that "github.base_ref" is only populated for pull_request. Push's also occur. A push happens when a PR is merged in to the develop branch. So this code change allows for both cases

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (5306a70) to head (9a5d6e5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3044   +/-   ##
========================================
  Coverage    91.76%   91.76%           
========================================
  Files          485      485           
  Lines        18777    18777           
========================================
  Hits         17231    17231           
  Misses        1546     1546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten requested a review from TedThemistokleous May 6, 2024 22:43
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
9a5d6e
Rate old
2bdd02
Diff Compare
torchvision-resnet50 64 2,790.07 2,788.87 0.04%
torchvision-resnet50_fp16 64 6,194.23 6,196.99 -0.04%
torchvision-densenet121 32 2,065.98 2,087.86 -1.05%
torchvision-densenet121_fp16 32 3,617.20 3,619.89 -0.07%
torchvision-inceptionv3 32 1,597.53 1,598.50 -0.06%
torchvision-inceptionv3_fp16 32 2,556.54 2,554.38 0.08%
cadene-inceptionv4 16 715.23 715.19 0.01%
cadene-resnext64x4 16 677.68 677.50 0.03%
slim-mobilenet 64 5,815.49 5,813.95 0.03%
slim-nasnetalarge 64 154.23 154.35 -0.08%
slim-resnet50v2 64 2,579.10 2,577.86 0.05%
bert-mrpc-onnx 8 969.17 968.76 0.04%
bert-mrpc-tf 1 403.79 404.07 -0.07%
pytorch-examples-wlang-gru 1 395.79 398.26 -0.62%
pytorch-examples-wlang-lstm 1 388.49 373.03 4.14% 🔆
torchvision-resnet50_1 1 599.55 600.53 -0.16%
cadene-dpn92_1 1 387.93 389.27 -0.35%
cadene-resnext101_1 1 323.35 323.24 0.03%
onnx-taau-downsample 1 306.54 306.73 -0.06%
dlrm-criteoterabyte 1 28.53 28.52 0.04%
dlrm-criteoterabyte_fp16 1 47.19 47.20 -0.03%
agentmodel 1 7,278.18 7,414.66 -1.84%
unet_fp16 2 57.54 57.49 0.08%
resnet50v1_fp16 1 879.17 906.84 -3.05% 🔴
resnet50v1_int8 1 791.59 797.10 -0.69%
bert_base_cased_fp16 64 1,022.21 1,022.34 -0.01%
bert_large_uncased_fp16 32 298.95 298.85 0.03%
bert_large_fp16 1 156.34 156.43 -0.06%
distilgpt2_fp16 16 1,835.21 1,833.22 0.11%
yolov5s 1 473.02 474.13 -0.23%
tinyllama 1 32.99 32.97 0.06%
vicuna-fastchat 1 158.13 158.78 -0.41%
whisper-tiny-encoder 1 352.95 354.39 -0.41%
whisper-tiny-decoder 1 400.39 402.35 -0.49%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit 49aff39 into develop May 7, 2024
20 checks passed
@causten causten deleted the license branch May 7, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants