-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support two outputs in split_reduce #3097
Conversation
return {rsum2, rsum1}; | ||
}); | ||
auto rsum2 = mm->add_instruction(migraphx::make_op("get_tuple_elem", {{"index", 0}}), rsum); | ||
auto rsum1 = mm->add_instruction(migraphx::make_op("get_tuple_elem", {{"index", 1}}), rsum); | ||
auto mul = | ||
add_pointwise(p2, mm, "main:pointwise1", {rsum1, rsum2}, single_pointwise("mul")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rsum2
is at tuple elem index 0
and rsum1
is at tuple elem index 1.
Which can be error prone.
This PR fails to compile if i run |
This currently will not fuse This is what happens with #3212
|
Yea we need to support multi-output fusion in the future. We can probably just do the fusion initially with mlir. |
This is fixed. |
Co-authored-by: Umang Yadav <[email protected]>
Co-authored-by: Umang Yadav <[email protected]>
…GraphX into split-reduce2
No description provided.