Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move up pybind to support new builds of ONNX Runtime #3121

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

causten
Copy link
Collaborator

@causten causten commented May 25, 2024

We build pybind as part of the requirements.txt file. The commit hash is from 2020. I discovered this 2020 version is now incompatible with upstream ONNX Runtime. I moved the commit hash to the lasted tagged release March 2024. Now ORT tip builds fine

@causten causten requested review from CharlieL7 and kahmed10 May 25, 2024 05:34
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
994d09
Rate old
bceef1
Diff Compare
torchvision-resnet50 64 1,713.66 1,714.31 -0.04%
torchvision-resnet50_fp16 64 3,809.75 3,599.39 5.84% 🔆
torchvision-densenet121 32 1,454.84 1,441.59 0.92%
torchvision-densenet121_fp16 32 2,428.95 2,401.25 1.15%
torchvision-inceptionv3 32 883.44 879.90 0.40%
torchvision-inceptionv3_fp16 32 1,379.16 1,056.41 30.55% 🔆
cadene-inceptionv4 16 407.61 389.80 4.57% 🔆
cadene-resnext64x4 16 413.63 413.92 -0.07%
slim-mobilenet 64 3,822.95 3,817.04 0.15%
slim-nasnetalarge 64 97.04 97.03 0.01%
slim-resnet50v2 64 1,651.58 1,650.54 0.06%
bert-mrpc-onnx 8 590.64 590.78 -0.02%
bert-mrpc-tf 1 283.37 284.82 -0.51%
pytorch-examples-wlang-gru 1 302.23 329.13 -8.17% 🔴
pytorch-examples-wlang-lstm 1 267.55 300.44 -10.95% 🔴
torchvision-resnet50_1 1 453.23 445.33 1.77%
cadene-dpn92_1 1 243.42 242.07 0.56%
cadene-resnext101_1 1 189.15 189.14 0.01%
onnx-taau-downsample 1 203.98 203.95 0.02%
dlrm-criteoterabyte 1 21.86 21.87 -0.06%
dlrm-criteoterabyte_fp16 1 41.41 40.69 1.77%
agentmodel 1 5,993.37 7,368.55 -18.66% 🔴
unet_fp16 2 33.74 33.73 0.04%
resnet50v1_fp16 1 529.39 538.15 -1.63%
resnet50v1_int8 1 461.77 456.39 1.18%
bert_base_cased_fp16 64 620.70 620.86 -0.03%
bert_large_uncased_fp16 32 193.78 193.85 -0.03%
bert_large_fp16 1 103.97 103.93 0.04%
distilgpt2_fp16 16 1,188.22 1,186.79 0.12%
yolov5s 1 297.59 297.03 0.19%
tinyllama 1 23.31 23.33 -0.06%
vicuna-fastchat 1 134.28 134.40 -0.09%
whisper-tiny-encoder 1 240.69 240.77 -0.04%
whisper-tiny-decoder 1 245.54 245.31 0.09%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (bceef13) to head (994d09b).
Report is 158 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3121   +/-   ##
========================================
  Coverage    91.82%   91.82%           
========================================
  Files          486      486           
  Lines        18991    18991           
========================================
  Hits         17438    17438           
  Misses        1553     1553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten merged commit 2dcca47 into develop May 27, 2024
46 checks passed
@causten causten deleted the bumppybind branch May 27, 2024 19:03
lajagapp pushed a commit to lajagapp/AMDMIGraphX that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants