Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROCm base image build #3134

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix ROCm base image build #3134

merged 1 commit into from
May 30, 2024

Conversation

IgorMirosavljevicHTEC
Copy link
Collaborator

New inputs added to reflect changes in base dockerfile

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (30cab64) to head (439f8c1).
Report is 147 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3134   +/-   ##
========================================
  Coverage    91.92%   91.92%           
========================================
  Files          489      489           
  Lines        19275    19275           
========================================
  Hits         17719    17719           
  Misses        1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
439f8c
Rate old
30cab6
Diff Compare
torchvision-resnet50 64 1,713.74 1,713.85 -0.01%
torchvision-resnet50_fp16 64 3,809.03 3,810.00 -0.03%
torchvision-densenet121 32 1,455.62 1,453.61 0.14%
torchvision-densenet121_fp16 32 2,436.42 2,437.45 -0.04%
torchvision-inceptionv3 32 883.34 883.14 0.02%
torchvision-inceptionv3_fp16 32 1,415.30 1,415.16 0.01%
cadene-inceptionv4 16 407.07 407.50 -0.11%
cadene-resnext64x4 16 413.74 413.59 0.04%
slim-mobilenet 64 3,822.36 3,820.83 0.04%
slim-nasnetalarge 64 97.02 97.03 -0.01%
slim-resnet50v2 64 1,651.81 1,651.24 0.03%
bert-mrpc-onnx 8 589.39 590.73 -0.23%
bert-mrpc-tf 1 288.58 289.90 -0.45%
pytorch-examples-wlang-gru 1 379.94 351.58 8.07% 🔆
pytorch-examples-wlang-lstm 1 300.31 299.62 0.23%
torchvision-resnet50_1 1 452.06 455.92 -0.85%
cadene-dpn92_1 1 244.65 244.63 0.01%
cadene-resnext101_1 1 189.18 187.95 0.65%
onnx-taau-downsample 1 204.07 204.11 -0.02%
dlrm-criteoterabyte 1 22.29 22.30 -0.05%
dlrm-criteoterabyte_fp16 1 41.62 41.61 0.01%
agentmodel 1 6,007.77 6,092.92 -1.40%
unet_fp16 2 33.72 33.74 -0.06%
resnet50v1_fp16 1 549.10 570.97 -3.83% 🔴
resnet50v1_int8 1 463.81 463.87 -0.01%
bert_base_cased_fp16 64 620.61 620.81 -0.03%
bert_large_uncased_fp16 32 193.74 193.83 -0.04%
bert_large_fp16 1 103.93 103.97 -0.04%
distilgpt2_fp16 16 1,186.15 1,189.15 -0.25%
yolov5s 1 298.44 298.14 0.10%
tinyllama 1 23.33 23.33 0.02%
vicuna-fastchat 1 134.06 133.18 0.67%
whisper-tiny-encoder 1 240.91 240.81 0.04%
whisper-tiny-decoder 1 245.54 245.89 -0.14%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit 3f9523b into develop May 30, 2024
21 checks passed
@causten causten deleted the fix_rocm_base_image_build_wf branch May 30, 2024 13:30
lajagapp pushed a commit to lajagapp/AMDMIGraphX that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants