Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLIR conv3d support #3138

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Add MLIR conv3d support #3138

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06f50f8
Add mlir conv3d support
turneram May 30, 2024
3e63812
Merge branch 'develop' into mlir-3dconv
causten Jun 5, 2024
28ce3f5
temporarily enable only on Windows
apwojcik Jun 7, 2024
b3fc6b8
Merge branch 'develop' into mlir-3dconv
apwojcik Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/targets/gpu/fuse_mlir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ auto is_mlir_conv(mlir_mode mode)
value v = ins->get_operator().to_value();
auto group = v.at("group").to<int>();
// Avoid MLIR assertion: Index < Length && "Invalid index!"
if(ins->get_shape().lens().size() != 4)
if(ins->get_shape().lens().size() != 4 and group > 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have performance comparsions between MIOpen's 3D /1D Convs and MLIR's for all dtypes across all hardwares ?

It may not make sense to enable it all the time otherwise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! Let's go with it and merge :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apwojcik do you have data points for that ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turneram @apwojcik can you please make this change enable only on windows for now ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

return false;
if(contains({shape::fp8e4m3fnuz_type, shape::int8_type}, input.type()))
return true;
Expand Down
Loading