Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libmigraphx_onnx.so a private library #3184

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

ahsan-ca
Copy link
Contributor

@ahsan-ca ahsan-ca commented Jun 14, 2024

Since libmigraphx_onnx.so has unstable ABI, we would like to make it private. This was missed in the earlier change #3108.

@ahsan-ca ahsan-ca added the enhancement New feature or request label Jun 14, 2024
@ahsan-ca ahsan-ca self-assigned this Jun 14, 2024
@ahsan-ca ahsan-ca requested a review from causten as a code owner June 14, 2024 20:42
@TedThemistokleous TedThemistokleous added simple small or simple changes bugfix Fixes a bug found in the code. labels Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (a05069e) to head (ac53b15).
Report is 146 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3184   +/-   ##
========================================
  Coverage    91.99%   91.99%           
========================================
  Files          489      489           
  Lines        19421    19421           
========================================
  Hits         17867    17867           
  Misses        1554     1554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahsan-ca ahsan-ca linked an issue Jun 14, 2024 that may be closed by this pull request
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
ac53b1
Rate old
e2af6d
Diff Compare
torchvision-resnet50 64 1,751.78 3,086.54 -43.24% 🔴
torchvision-resnet50_fp16 64 4,084.55 6,427.70 -36.45% 🔴
torchvision-densenet121 32 1,466.18 2,392.11 -38.71% 🔴
torchvision-densenet121_fp16 32 2,529.98 3,875.59 -34.72% 🔴
torchvision-inceptionv3 32 889.45 1,615.36 -44.94% 🔴
torchvision-inceptionv3_fp16 32 1,483.57 2,563.79 -42.13% 🔴
cadene-inceptionv4 16 412.50 754.68 -45.34% 🔴
cadene-resnext64x4 16 419.83 770.40 -45.50% 🔴
slim-mobilenet 64 4,009.55 6,855.84 -41.52% 🔴
slim-nasnetalarge 64 101.03 177.36 -43.04% 🔴
slim-resnet50v2 64 1,680.82 2,885.89 -41.76% 🔴
bert-mrpc-onnx 8 616.94 1,105.75 -44.21% 🔴
bert-mrpc-tf 1 279.37 462.37 -39.58% 🔴
pytorch-examples-wlang-gru 1 320.87 342.03 -6.19% 🔴
pytorch-examples-wlang-lstm 1 295.50 302.22 -2.22%
torchvision-resnet50_1 1 464.69 452.00 2.81%
cadene-dpn92_1 1 245.12 244.40 0.29%
cadene-resnext101_1 1 204.50 189.14 8.12% 🔆
onnx-taau-downsample 1 206.48 204.24 1.10%
dlrm-criteoterabyte 1 22.90 22.28 2.79%
dlrm-criteoterabyte_fp16 1 42.71 41.62 2.62%
agentmodel 1 6,189.69 6,184.90 0.08%
unet_fp16 2 34.24 34.24 0.01%
resnet50v1_fp16 1 596.11 546.64 9.05% 🔆
resnet50v1_int8 1 571.98 462.83 23.58% 🔆
bert_base_cased_fp16 64 646.30 623.57 3.65% 🔆
bert_large_uncased_fp16 32 199.06 194.34 2.43%
bert_large_fp16 1 117.38 104.08 12.78% 🔆
distilgpt2_fp16 16 1,211.67 1,191.88 1.66%
yolov5s 1 301.73 498.03 -39.41% 🔴
tinyllama 1 23.33 43.69 -46.61% 🔴
vicuna-fastchat 1 132.30 184.01 -28.10% 🔴
whisper-tiny-encoder 1 244.47 405.70 -39.74% 🔴
whisper-tiny-decoder 1 256.86 418.00 -38.55% 🔴

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@umangyadav umangyadav merged commit eed559f into develop Jun 17, 2024
47 checks passed
@umangyadav umangyadav deleted the private-onnx-lib branch June 17, 2024 12:28
lajagapp pushed a commit to lajagapp/AMDMIGraphX that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code. enhancement New feature or request simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make libmigraphx_onnx.so a private library
4 participants