-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make libmigraphx_onnx.so a private library #3184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedThemistokleous
approved these changes
Jun 14, 2024
TedThemistokleous
added
simple
small or simple changes
bugfix
Fixes a bug found in the code.
labels
Jun 14, 2024
umangyadav
approved these changes
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3184 +/- ##
========================================
Coverage 91.99% 91.99%
========================================
Files 489 489
Lines 19421 19421
========================================
Hits 17867 17867
Misses 1554 1554 ☔ View full report in Codecov by Sentry. |
This build is not recommended to merge 🔴 |
🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
causten
pushed a commit
that referenced
this pull request
Jun 26, 2024
lajagapp
pushed a commit
to lajagapp/AMDMIGraphX
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Fixes a bug found in the code.
enhancement
New feature or request
simple
small or simple changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libmigraphx_onnx.so has unstable ABI, we would like to make it private. This was missed in the earlier change #3108.