Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning about wrong use of export #3237

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix warning about wrong use of export #3237

merged 2 commits into from
Jul 3, 2024

Conversation

apwojcik
Copy link
Collaborator

@apwojcik apwojcik commented Jul 1, 2024

We are turning on -Werror on Windows builds. That warning breaks it all. We need this PR in 6.2, too.

@apwojcik apwojcik added bugfix Fixes a bug found in the code. high priority A PR with high priority for review and merging. Windows Related changes for Windows Environments UAI labels Jul 1, 2024
@apwojcik apwojcik requested a review from causten as a code owner July 1, 2024 12:01
@apwojcik apwojcik changed the title fix warning about wrong use export fix warning about wrong use of export Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (497c277) to head (13cecf3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3237   +/-   ##
========================================
  Coverage    92.16%   92.16%           
========================================
  Files          493      493           
  Lines        19690    19690           
========================================
  Hits         18148    18148           
  Misses        1542     1542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Jul 1, 2024

Test Batch Rate new
13cecf
Rate old
3e6503
Diff Compare
torchvision-resnet50 64 1,749.26 1,743.65 0.32%
torchvision-resnet50_fp16 64 4,080.33 4,044.51 0.89%
torchvision-densenet121 32 1,466.89 1,463.38 0.24%
torchvision-densenet121_fp16 32 2,524.38 2,522.64 0.07%
torchvision-inceptionv3 32 888.91 876.68 1.40%
torchvision-inceptionv3_fp16 32 1,483.81 1,486.04 -0.15%
cadene-inceptionv4 16 412.10 407.11 1.22%
cadene-resnext64x4 16 419.24 419.10 0.03%
slim-mobilenet 64 4,004.03 4,089.22 -2.08%
slim-nasnetalarge 64 100.96 101.10 -0.13%
slim-resnet50v2 64 1,679.67 1,684.72 -0.30%
bert-mrpc-onnx 8 615.76 616.20 -0.07%
bert-mrpc-tf 1 280.29 280.27 0.01%
pytorch-examples-wlang-gru 1 322.17 325.41 -1.00%
pytorch-examples-wlang-lstm 1 293.16 296.35 -1.08%
torchvision-resnet50_1 1 469.13 474.28 -1.09%
cadene-dpn92_1 1 247.60 246.84 0.31%
cadene-resnext101_1 1 204.25 205.64 -0.68%
onnx-taau-downsample 1 205.89 204.56 0.65%
dlrm-criteoterabyte 1 22.90 22.91 -0.03%
dlrm-criteoterabyte_fp16 1 42.72 42.68 0.10%
agentmodel 1 6,329.19 6,268.69 0.97%
unet_fp16 2 34.32 34.29 0.08%
resnet50v1_fp16 1 595.15 586.62 1.45%
resnet50v1_int8 1 564.91 589.52 -4.17% 🔴
bert_base_cased_fp16 64 645.88 645.93 -0.01%
bert_large_uncased_fp16 32 198.84 198.87 -0.02%
bert_large_fp16 1 117.29 117.44 -0.13%
distilgpt2_fp16 16 1,209.37 1,212.53 -0.26%
yolov5s 1 302.15 301.95 0.07%
tinyllama 1 23.32 23.32 0.02%
vicuna-fastchat 1 134.08 133.36 0.54%
whisper-tiny-encoder 1 244.36 244.01 0.14%
whisper-tiny-decoder 1 255.91 255.81 0.04%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@umangyadav umangyadav merged commit e2d6efb into develop Jul 3, 2024
43 of 46 checks passed
@umangyadav umangyadav deleted the fix_wrong_export branch July 3, 2024 19:32
umangyadav pushed a commit that referenced this pull request Jul 4, 2024
lajagapp pushed a commit to lajagapp/AMDMIGraphX that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code. high priority A PR with high priority for review and merging. UAI Windows Related changes for Windows Environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants