-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in find_concat_op when input broadcasts are on different axes #3242
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3242 +/- ##
===========================================
+ Coverage 92.16% 92.20% +0.03%
===========================================
Files 493 493
Lines 19690 19700 +10
===========================================
+ Hits 18148 18164 +16
+ Misses 1542 1536 -6 ☔ View full report in Codecov by Sentry. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
@@ -811,6 +811,18 @@ struct find_concat_op | |||
op.attributes().contains("pointwise"); | |||
} | |||
|
|||
static bool is_valid_concat(std::vector<instruction_ref> ins, size_t axis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is another bug on line 886
auto pred = [](auto i, auto j) {
return i->get_operator() == j->get_operator() and
i->inputs().size() == i->inputs().size() and
i->outputs().size() == i->outputs().size();
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking in #3245
Fixes issue #3224
Which in turn fixes one of the issues exposed by #3104