-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find_splits bugfix #3244
Merged
Merged
find_splits bugfix #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3244 +/- ##
===========================================
+ Coverage 92.20% 92.21% +0.01%
===========================================
Files 493 493
Lines 19700 19725 +25
===========================================
+ Hits 18164 18190 +26
+ Misses 1536 1535 -1 ☔ View full report in Codecov by Sentry. |
umangyadav
reviewed
Jul 4, 2024
umangyadav
approved these changes
Jul 8, 2024
TedThemistokleous
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3218
Given a set of ops:
input: {2, 4, 4} -> slc1 {2,2,4}, slc2 {2,2,4} -> add(c1, slc1), add(c2, slc2)
Current logic assumes that the slices are always at the same input location in the binary op. This PR handles the case when graph has something like the following instead:
input: {2, 4, 4} -> slc1 {2,2,4}, slc2 {2,2,4} -> add(slc1, c1), add(c2, slc2)
In this case
add
is a commutative op so this simplification can still be done, so we force all the slices to be at input 0. In the case of non commutative ops, the matcher will return without performing a simplification.