Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out qlinear reuse matcher #3264

Closed
wants to merge 2 commits into from

Conversation

CharlieL7
Copy link
Collaborator

Comment out the qlinear_reused matcher because of an accuracy error for quantized resnet50

@CharlieL7 CharlieL7 added the bugfix Fixes a bug found in the code. label Jul 10, 2024
@CharlieL7 CharlieL7 self-assigned this Jul 10, 2024
@CharlieL7 CharlieL7 requested a review from causten as a code owner July 10, 2024 20:45
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (d15a23a) to head (280a304).
Report is 9 commits behind head on release/rocm-rel-6.2.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/rocm-rel-6.2    #3264   +/-   ##
=====================================================
  Coverage                 92.00%   92.00%           
=====================================================
  Files                       489      489           
  Lines                     19368    19344   -24     
=====================================================
- Hits                      17819    17797   -22     
+ Misses                     1549     1547    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umangyadav
Copy link
Member

Is this required if we were to pull in changes from MLIR ?

@CharlieL7
Copy link
Collaborator Author

Is this required if we were to pull in changes from MLIR ?

We won't hit the verify "accuracy" bug for the quantized resnet50 model with the change from MLIR. However, the matcher itself is questionable. I'm proposing to remove it permanently here in #3269.

@pfultz2
Copy link
Collaborator

pfultz2 commented Jul 24, 2024

We won't hit the verify "accuracy" bug for the quantized resnet50 model with the change from MLIR.

If we dont hit an accuracy error then we shouldn't remove it.

@CharlieL7
Copy link
Collaborator Author

CharlieL7 commented Jul 24, 2024

We won't hit the verify "accuracy" bug for the quantized resnet50 model with the change from MLIR.

If we dont hit an accuracy error then we shouldn't remove it.

Matcher accuracy is brittle, if we change the randomized values slightly it will even fail without MLIR.

@CharlieL7
Copy link
Collaborator Author

Closing: Should be able to pass verify accuracy with this compiler pass enable with the MLIR fix ROCm/rocMLIR#1567

@CharlieL7 CharlieL7 closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants