-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment out qlinear reuse matcher #3264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/rocm-rel-6.2 #3264 +/- ##
=====================================================
Coverage 92.00% 92.00%
=====================================================
Files 489 489
Lines 19368 19344 -24
=====================================================
- Hits 17819 17797 -22
+ Misses 1549 1547 -2 ☔ View full report in Codecov by Sentry. |
Is this required if we were to pull in changes from MLIR ? |
We won't hit the verify "accuracy" bug for the quantized resnet50 model with the change from MLIR. However, the matcher itself is questionable. I'm proposing to remove it permanently here in #3269. |
If we dont hit an accuracy error then we shouldn't remove it. |
Matcher accuracy is brittle, if we change the randomized values slightly it will even fail without MLIR. |
Closing: Should be able to pass verify accuracy with this compiler pass enable with the MLIR fix ROCm/rocMLIR#1567 |
Comment out the qlinear_reused matcher because of an accuracy error for quantized resnet50