Find dot slice #3268
Merged
Find dot slice #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3268 +/- ##
===========================================
+ Coverage 92.21% 92.23% +0.01%
===========================================
Files 493 493
Lines 19725 19770 +45
===========================================
+ Hits 18190 18234 +44
- Misses 1535 1536 +1 ☔ View full report in Codecov by Sentry. |
CharlieL7
approved these changes
Jul 16, 2024
src/simplify_algebra.cpp
Outdated
Comment on lines
286
to
292
| auto has_neg_vals = [](auto vec) { | ||
| return std::any_of(vec.begin(), vec.end(), [](auto i) { return i < 0; }); | ||
| }; | ||
| if(has_neg_vals(starts) or has_neg_vals(ends) or has_neg_vals(axes)) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Maybe this should be a throw or a warning because having a negative value here would probably be a problem.
There was a problem hiding this comment.
We have normlize_ops pass which runs at the beginning which would convert all the neg axes to positive ones.
Therefore this case should never arise and retuning simply is okay.
There was a problem hiding this comment.
I think it should print a warning if possible, otherwise if we mess something up wrt. normalize_ops this could be passed over without us knowing.
There was a problem hiding this comment.
made changes to use "normalized_operator" and also enabled test for neg vals.
shivadbhavsar
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3267
Didn't add verify tests since they are already covered through GRU/RNN tests.