Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fixes for generic_float #3607

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Windows fixes for generic_float #3607

merged 3 commits into from
Nov 11, 2024

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Nov 9, 2024

This is similar to #3599, but passes the tests. There is no macro, and all_ones function doesn't change, so there is less code changes here.

@pfultz2 pfultz2 requested a review from causten as a code owner November 9, 2024 00:54
@pfultz2 pfultz2 requested review from richagadgil, CharlieL7 and apwojcik and removed request for causten November 9, 2024 01:23
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (f5df004) to head (1015d51).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3607   +/-   ##
========================================
  Coverage    92.17%   92.17%           
========================================
  Files          513      513           
  Lines        21536    21537    +1     
========================================
+ Hits         19851    19852    +1     
  Misses        1685     1685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
1015d5
Rate old
f5df00
Diff Compare
torchvision-resnet50 64 3,260.13 3,258.22 0.06%
torchvision-resnet50_fp16 64 6,985.56 6,994.86 -0.13%
torchvision-densenet121 32 2,435.89 2,438.08 -0.09%
torchvision-densenet121_fp16 32 4,104.17 4,082.99 0.52%
torchvision-inceptionv3 32 1,637.41 1,637.00 0.03%
torchvision-inceptionv3_fp16 32 2,766.04 2,762.55 0.13%
cadene-inceptionv4 16 776.73 776.12 0.08%
cadene-resnext64x4 16 810.66 811.97 -0.16%
slim-mobilenet 64 7,541.02 7,534.11 0.09%
slim-nasnetalarge 64 211.43 211.46 -0.01%
slim-resnet50v2 64 3,501.82 3,503.66 -0.05%
bert-mrpc-onnx 8 1,151.06 1,150.99 0.01%
bert-mrpc-tf 1 466.22 494.60 -5.74% 🔴
pytorch-examples-wlang-gru 1 528.74 428.98 23.25% 🔆
pytorch-examples-wlang-lstm 1 406.37 385.66 5.37% 🔆
torchvision-resnet50_1 1 784.50 766.70 2.32%
cadene-dpn92_1 1 408.99 433.66 -5.69% 🔴
cadene-resnext101_1 1 383.37 383.99 -0.16%
onnx-taau-downsample 1 342.55 343.15 -0.17%
dlrm-criteoterabyte 1 33.32 33.33 -0.03%
dlrm-criteoterabyte_fp16 1 52.74 52.72 0.03%
agentmodel 1 8,310.41 8,297.10 0.16%
unet_fp16 2 58.88 58.77 0.19%
resnet50v1_fp16 1 1,044.55 948.38 10.14% 🔆
resnet50v1_int8 1 997.70 1,046.77 -4.69% 🔴
bert_base_cased_fp16 64 1,172.03 1,171.13 0.08%
bert_large_uncased_fp16 32 363.86 363.68 0.05%
bert_large_fp16 1 198.34 197.66 0.34%
distilgpt2_fp16 16 2,201.55 2,203.57 -0.09%
yolov5s 1 521.20 549.13 -5.09% 🔴
tinyllama 1 43.47 43.43 0.09%
vicuna-fastchat 1 172.45 169.54 1.71%
whisper-tiny-encoder 1 418.19 418.17 0.00%
whisper-tiny-decoder 1 426.78 428.69 -0.44%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit a435c28 into develop Nov 11, 2024
33 of 37 checks passed
@causten causten deleted the generic-float-fixes branch November 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants