Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and keyword consistently #3676

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Use and keyword consistently #3676

wants to merge 3 commits into from

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Dec 4, 2024

Also, enable clang tidy to check for this.

@pfultz2 pfultz2 requested a review from causten as a code owner December 4, 2024 01:36
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
fb35b3
Rate old
241e24
Diff Compare
torchvision-resnet50 64 3,257.64 3,256.24 0.04%
torchvision-resnet50_fp16 64 6,992.95 6,984.56 0.12%
torchvision-densenet121 32 2,410.82 2,434.44 -0.97%
torchvision-densenet121_fp16 32 4,084.33 4,078.22 0.15%
torchvision-inceptionv3 32 1,628.79 1,629.38 -0.04%
torchvision-inceptionv3_fp16 32 2,748.79 2,742.92 0.21%
cadene-inceptionv4 16 764.82 764.47 0.05%
cadene-resnext64x4 16 812.40 812.01 0.05%
slim-mobilenet 64 7,461.29 7,468.13 -0.09%
slim-nasnetalarge 64 208.49 208.51 -0.01%
slim-resnet50v2 64 3,439.45 3,440.29 -0.02%
bert-mrpc-onnx 8 1,148.06 1,148.20 -0.01%
bert-mrpc-tf 1 468.40 464.32 0.88%
pytorch-examples-wlang-gru 1 498.68 426.54 16.91% 🔆
pytorch-examples-wlang-lstm 1 388.00 380.15 2.06%
torchvision-resnet50_1 1 789.50 775.13 1.85%
cadene-dpn92_1 1 435.59 403.98 7.83% 🔆
cadene-resnext101_1 1 384.00 383.04 0.25%
onnx-taau-downsample 1 345.94 345.85 0.03%
dlrm-criteoterabyte 1 33.34 33.33 0.04%
dlrm-criteoterabyte_fp16 1 52.51 52.75 -0.45%
agentmodel 1 8,645.88 8,145.38 6.14% 🔆
unet_fp16 2 58.95 58.93 0.03%
resnet50v1_fp16 1 920.52 935.00 -1.55%
resnet50v1_int8 1 1,039.96 1,023.68 1.59%
bert_base_cased_fp16 64 1,170.75 1,169.83 0.08%
bert_large_uncased_fp16 32 363.18 363.35 -0.05%
bert_large_fp16 1 201.37 195.75 2.87%
distilgpt2_fp16 16 2,197.95 2,196.59 0.06%
yolov5s 1 531.38 534.53 -0.59%
tinyllama 1 43.37 43.39 -0.04%
vicuna-fastchat 1 173.10 171.47 0.95%
whisper-tiny-encoder 1 418.15 417.49 0.16%
whisper-tiny-decoder 1 430.14 427.46 0.63%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link
Collaborator

@TedThemistokleous TedThemistokleous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in lowering.cpp as well

@TedThemistokleous TedThemistokleous added the Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants