Driver quantize fp8 update #3715
Open
+2
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CharlieL7
commented
Dec 13, 2024
•
CharlieL7
commented
- Updates the quantization to always quantize fp8 to the OCP fp8e4m3fn type
- Removes running simplify_qdq and optimize_module during the quantization so that the ocp_to_fnuz conversion pass can work properly
- Don't merge this until FP8 OCP to FP8 FNUZ on hardware with only FP8 FNUZ support #3684 is done.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ocp_to_fnuz #3715 +/- ##
===============================================
+ Coverage 92.23% 92.25% +0.02%
===============================================
Files 517 517
Lines 21819 21808 -11
===============================================
- Hits 20124 20120 -4
+ Misses 1695 1688 -7 ☔ View full report in Codecov by Sentry. |
pfultz2
reviewed
Dec 13, 2024
| @@ -311,7 +311,6 @@ struct context | |||
| value result; | |||
| result["events"] = events.size(); | |||
| result["streams"] = current_device->nstreams(); | |||
| result["gfx_name"] = get_current_device().get_gfx_name(); | |||
There was a problem hiding this comment.
Why is this removed on serialization?
There was a problem hiding this comment.
I added this earlier when getting FP8 OCP in to query the gfx number from the driver. We could keep it, but it would not be used anywhere anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.