Enable cpp core guidlines checks. #3723
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3723 +/- ##
========================================
Coverage 92.16% 92.16%
========================================
Files 515 515
Lines 21978 21978
========================================
Hits 20256 20256
Misses 1722 1722 ☔ View full report in Codecov by Sentry. |
causten
approved these changes
Dec 20, 2024
TedThemistokleous
approved these changes
Dec 20, 2024
TedThemistokleous
added
the
Cleanup
|
This is still missing enabling the |
Thanks for pointing it out, the check is enabled now. |
TedThemistokleous
approved these changes
Dec 21, 2024
pfultz2
reviewed
Dec 21, 2024
| @@ -171,9 +171,10 @@ TEST_CASE(fp32_fp16_test) | |||
| }; | |||
|
|
|||
| auto test_case = [&](std::vector<std::string>&& op_names) { | |||
There was a problem hiding this comment.
Function parameter should be const-ref.
pfultz2
reviewed
Dec 21, 2024
| @@ -894,15 +894,16 @@ void program::mark(const parameter_map& params, marker&& m) | |||
| eval(params); | |||
| this->finish(); | |||
| // Start marking | |||
| m.mark_start(*this); | |||
| auto moved_marker = std::move(m); | |||
There was a problem hiding this comment.
Take the marker by value instead of forcing a move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2231