Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MIOpen version to 3.1.0 and update CI docker #2519
Bump MIOpen version to 3.1.0 and update CI docker #2519
Changes from 5 commits
309309b
61e1721
58c4d97
39572c0
4a011d1
58f8d80
7eefad5
ed1a732
8053a0c
f958b46
08a1ca3
699cf08
3e847da
72eb180
10e9581
f498789
8bc23eb
69c0d99
aa09f36
cf02a64
ebeef1d
ee34b45
dab5d3b
c6b4352
b35b497
9990a5d
5b00521
0133956
dc55bba
0d48eb3
19b1a95
592d5cb
e74ed6d
f92cd4c
b81d3a5
c43de0c
b4d1236
41c6172
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Q] Where we'll take half after this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
apt-get install half
? :)Now if we use
amdgpu-install -y --usecase=rocm
as part of the dockerfile script, bothhalf
andcomposablekernel
will be pre-installed. Then if we try to install it via building dependencies there will be errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junliume I recommend keeping this, but commenting this out with
#
(and maybe putting some short explanation). This may be useful for clients who use previous version of ROCm which does not installhalf
by default.