-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MIOpen version to 3.1.0 and update CI docker #2519
Merged
Merged
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
309309b
Update docker and miopen version
atamazov 61e1721
update FIN to develop
atamazov 58c4d97
update a few more requirements
junliume 39572c0
overrisde existing installed files
junliume 4a011d1
purge CK before installing new
junliume 58f8d80
fix hip tidy issues
junliume 7eefad5
add a few missing ones
junliume ed1a732
adopt review opinion
junliume 8053a0c
Update CMakeLists.txt
junliume f958b46
fix issues typo and hiprtc header
junliume 08a1ca3
Merge branch 'develop' into bump_version_fin
junliume 699cf08
Keep base docker at Ubuntu 20.04
junliume 3e847da
Revert limitations on limits header
junliume 72eb180
add fixes
umangyadav 10e9581
changes that works for MIGraphX
umangyadav f498789
rever changes for checknumerics
umangyadav 8bc23eb
Merge branch 'develop' into fp8_fix
umangyadav 69c0d99
Formatting
umangyadav aa09f36
Merge branch 'fp8_fix' into bump_version_fin
junliume cf02a64
update docker file
junliume ebeef1d
avoid ldd conflicts
junliume ee34b45
update CK commit hash
junliume dab5d3b
Merge branch 'develop' into bump_version_fin
junliume c6b4352
update dockerfile
junliume b35b497
Merge branch 'develop' into bump_version_fin
junliume 9990a5d
update dockerfile
junliume 5b00521
Merge branch 'develop' into bump_version_fin
junliume 0133956
workaround build issues of CK
junliume dc55bba
fix the real issue in compiling rocMLIR
junliume 0d48eb3
bump CK commit hash
junliume 19b1a95
WA for Issue 2600 and turn on smoke tests by default
junliume 592d5cb
ROCm 6.0 replaces all __HIP_PLATFORM_HCC__ with __HIP_PLATFORM_AMD__
junliume e74ed6d
Merge branch 'develop' into bump_version_fin
junliume f92cd4c
Update src/comgr.cpp
junliume b81d3a5
fix clang format issue
junliume c43de0c
Merge branch 'develop' into bump_version_fin
junliume b4d1236
Bump CK commit hash to d0f355a31a341b0a885ff65231781f332a20cc5f
junliume 41c6172
Merge branch 'develop' into bump_version_fin
junliume File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
ROCmSoftwarePlatform/rocm-recipes@d7b71f8ff71572833c8cf15b74279dd034e66f9d | ||
-f requirements.txt | ||
danmar/cppcheck@2.9 | ||
danmar/cppcheck@2.12.1 | ||
google/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
[email protected] -DCMAKE_POSITION_INDEPENDENT_CODE=On | ||
[email protected] -DCMAKE_POSITION_INDEPENDENT_CODE=On --build -DCMAKE_CXX_FLAGS=" -std=c++14 -Wno-enum-constexpr-conversion -Wno-deprecated-builtins -Wno-deprecated-declarations " | ||
facebook/[email protected] -X subdir -DCMAKE_DIR=build/cmake | ||
ROCmSoftwarePlatform/half@10abd99e7815f0ca5d892f58dd7d15a23b7cf92c --build | ||
ROCmSoftwarePlatform/[email protected] -H sha256:a5f62769d28a73e60bc8d61022820f050e97c977c8f6f6275488db31512e1f42 -DBUILD_FAT_LIBROCKCOMPILER=1 -DCMAKE_IGNORE_PATH=/opt/conda/envs/py_3.9 -DCMAKE_IGNORE_PREFIX_PATH=/opt/conda | ||
# ROCmSoftwarePlatform/half@10abd99e7815f0ca5d892f58dd7d15a23b7cf92c --build | ||
ROCmSoftwarePlatform/[email protected] -H sha256:a5f62769d28a73e60bc8d61022820f050e97c977c8f6f6275488db31512e1f42 -DBUILD_FAT_LIBROCKCOMPILER=1 -DCMAKE_IGNORE_PATH="/opt/conda/envs/py_3.8;/opt/conda/envs/py_3.9;/opt/conda/envs/py_3.10" -DCMAKE_IGNORE_PREFIX_PATH=/opt/conda | ||
nlohmann/[email protected] -DJSON_MultipleHeaders=ON -DJSON_BuildTests=Off | ||
ROCmSoftwarePlatform/[email protected] | ||
ROCmSoftwarePlatform/[email protected] | ||
ROCmSoftwarePlatform/frugally-deep@9683d557eb672ee2304f80f6682c51242d748a50 | ||
ROCmSoftwarePlatform/composable_kernel@0dacd895d5ba9c9eeb99588ec7f7df1da82f7fa9 -DCMAKE_BUILD_TYPE=Release -DINSTANCES_ONLY=ON | ||
ROCmSoftwarePlatform/composable_kernel@d0f355a31a341b0a885ff65231781f332a20cc5f -DCMAKE_BUILD_TYPE=Release -DINSTANCES_ONLY=ON |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
CheckOptions: | ||
- key: bugprone-reserved-identifier.AllowedIdentifiers | ||
value: '__HIP_PLATFORM_HCC__;__HIP_ROCclr__' | ||
value: '__HIP_PLATFORM_AMD__;__HIP_ROCclr__' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Q] Where we'll take half after this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
apt-get install half
? :)Now if we use
amdgpu-install -y --usecase=rocm
as part of the dockerfile script, bothhalf
andcomposablekernel
will be pre-installed. Then if we try to install it via building dependencies there will be errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junliume I recommend keeping this, but commenting this out with
#
(and maybe putting some short explanation). This may be useful for clients who use previous version of ROCm which does not installhalf
by default.