Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MI300 TunaNet Update: CK FWD and WRW Solvers Updated #3130

Merged
merged 2 commits into from
Aug 8, 2024
Merged

MI300 TunaNet Update: CK FWD and WRW Solvers Updated #3130

merged 2 commits into from
Aug 8, 2024

Conversation

msaudulhassan
Copy link
Collaborator

  • Updated TunaNet for MI300 to incorporate updates in the CK Fwd and CK Wrw grouped solvers
  • Documented heuristics code

@msaudulhassan msaudulhassan self-assigned this Jul 22, 2024
@msaudulhassan msaudulhassan mentioned this pull request Jul 22, 2024
Closed
@msaudulhassan
Copy link
Collaborator Author

This PR is affected by Issue#3129. However, the issue is not with TunaNet itself by rather the conv::ProblemDescription object that TunaNet uses to parse the convolution problem into the model's input vector. This PR can therefore go ahead

@junliume
Copy link
Collaborator

@msaudulhassan could you help to align with @bartekxk on this change? We reverted the change in CK first, if this PR conflicts again with the revert we need to issue two PRs (one in CK one in MIOpen) in a planned way. Thanks!

@junliume
Copy link
Collaborator

junliume commented Aug 1, 2024

@msaudulhassan any updates on this PR? Should it work together with necessary changes from CK?

@msaudulhassan
Copy link
Collaborator Author

@msaudulhassan any updates on this PR? Should it work together with necessary changes from CK?

This PR is good to be merged

@junliume junliume merged commit 25757a0 into develop Aug 8, 2024
140 of 141 checks passed
@junliume junliume deleted the saud/mi300_ck_fwd_wrw branch August 8, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iq136boy iq136boy iq136boy approved these changes

@junliume junliume junliume approved these changes

@cderb cderb cderb approved these changes

@JehandadKhan JehandadKhan Awaiting requested review from JehandadKhan JehandadKhan is a code owner

Assignees

@msaudulhassan msaudulhassan

Labels
IMPACTS_API TESTING_CI_PASSED urgency_high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msaudulhassan @junliume @iq136boy @cderb