Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated gtest formatting checks #3370

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Automated gtest formatting checks #3370

wants to merge 6 commits into from
+50 −0

Conversation

reidkwja
Copy link
Collaborator

@reidkwja reidkwja commented Nov 5, 2024

Checks for formatting rules in link upon push or changes in gtest directory.

@reidkwja reidkwja marked this pull request as ready for review November 7, 2024 20:00
CAHEK7
CAHEK7 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@CAHEK7 CAHEK7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just double checking - does the script detects missed INSTANTIATE_TEST_SUITE_P for TEST_P?

@junliume
Copy link
Collaborator

@reidkwja

/home/jenkins/workspace/MLLIBS_MIOpen_rk_gtestchecker@tmp/durable-b196ff28/script.sh: 16: ./test/utils/check_gtests.sh: not found

script returned exit code 127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAHEK7 CAHEK7 CAHEK7 approved these changes

@BrianHarrisonAMD BrianHarrisonAMD Awaiting requested review from BrianHarrisonAMD BrianHarrisonAMD is a code owner

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@bpepers-me bpepers-me Awaiting requested review from bpepers-me

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidkwja @junliume @CAHEK7