Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTests] Rename non-unique test names (TEST, TEST_P, TEST_F, TYPED_TEST). Part 2. #3449

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

Vsevolod1983
Copy link
Collaborator

When we use single test binary we should keep our test names unique (First parameter in TEST* macros). Otherwise, we get a lot of failures, which are not related to tests themselves. Non unique names create a conflict when get combined into one executable.

As an example of this extra failures from the ticket: SWDEV-488434
[ FAILED ] Full/GPU_UnitTestConvSolverBwd_FP16.ConvWinoFuryRxSf2x3/0, where GetParam() = (4-byte object , 0, (x:{2,64,128,128,128} w:{32,64,3,3,3} pad:{1,1,1} stride:{1,1,1} dilation:{1,1,1} type_x:0 type_w:0 type_y:0))

We can see that "ConvWinoFuryRxSf2x3" is never used in "Full" test suites. So we have reports about the failures in tests which even don't exist!

There will be series of PRs with renaming for easier reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant