Skip to content

Commit

Permalink
FIx test failures and add more tests for c_equal_d
Browse files Browse the repository at this point in the history
  • Loading branch information
jichangjichang committed Nov 5, 2024
1 parent b35e5a7 commit dd8fe36
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
4 changes: 3 additions & 1 deletion clients/gtest/matmul_gtest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1593,9 +1593,10 @@ Tests:
algo_method: [0,1]
transA_transB: *transA_transB_range
alpha: 1
beta: 0
beta: [0,1]
requested_solution_num: -1
unit_check: 1
c_equal_d: [0, 1]

- name: matmul_heuristic_all_solutions_real_1byte
category: nightly
Expand All @@ -1611,4 +1612,5 @@ Tests:
requested_solution_num: -1
unit_check: 1
gpu_arch: '94[0-2]'
c_equal_d: [0, 1]
...
14 changes: 14 additions & 0 deletions clients/include/testing_matmul.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2761,6 +2761,13 @@ void testing_matmul_with_bias(const Arguments& arg,
{
for(size_t sol = 0; sol < heuristicResult.size(); sol++)
{
if((arg.unit_check || arg.norm_check || arg.allclose_check) && arg.c_equal_d)
{
for(int i = 0; i < gemm_count; i++)
{
CHECK_HIP_ERROR(synchronize(dC[i], hC[i], block_count));
}
}
if(!do_grouped_gemm)
{
if(arg.use_ext)
Expand Down Expand Up @@ -2928,6 +2935,13 @@ void testing_matmul_with_bias(const Arguments& arg,

for(size_t sol = 0; sol < heuristicResult.size(); sol++)
{
if((arg.unit_check || arg.norm_check || arg.allclose_check) && arg.c_equal_d)
{
for(int i = 0; i < gemm_count; i++)
{
CHECK_HIP_ERROR(synchronize(dC[i], hC[i], block_count));
}
}
if(!do_grouped_gemm)
{
FrequencyMonitor& freq_monitor = getFrequencyMonitor();
Expand Down

0 comments on commit dd8fe36

Please sign in to comment.