Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove -fopenacc command line option" #197

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ronlieb
Copy link
Collaborator

@ronlieb ronlieb commented Oct 29, 2024

Reverts #187

@ronlieb ronlieb requested a review from dpalermo October 29, 2024 19:36
@dpalermo dpalermo merged commit 59cd748 into amd-trunk-dev Oct 29, 2024
3 of 5 checks passed
@ronlieb
Copy link
Collaborator Author

ronlieb commented Oct 29, 2024

thanks Dan, this will help with reducing lots of lit test conflicts and openacc going forward

@dpalermo
Copy link

I have created a smaller patch that reapplies the flag change but instead skips related tests by using lit.cfg excludes instead of deleting all of the unsupported tests. We also decided not to commit it on ATD to avoid increasing the delta at a time we are trying to shrink it. Instead, we will apply it as one of the additional patches on the AFAR so the desired behavior is seen by customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants