Add set_false_math to false to solve accuracy issue for gelu test. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will flip out of draft once DLM run passes. Then port to upstream once this review is complete |
causten
approved these changes
Nov 29, 2023
Allow users to set the fast math option for MIGraphX compilation for quantized data types (fp16) This allows us to toggle whether we can use faster math with the tradeoff of accuracy.
|
Waiting for a clean test run with latest changes. I'll merge this in morning if this works, or worst case for the sake of time back the most recent env variable changes out and add the flags later. |
added 3 commits
November 29, 2023 05:47
|
Just disabling everything for fast math by default for now. |
TedThemistokleous
merged commit d876d37
into
rocm6.0_internal_testing
10 of 12 checks passed
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for Navi3x cards as there's an issue we're seeing with fp16 fast math through MIGraphX.
Turning off the fast math via the compiler options solves this through the EP side. Will disable fast math by default and enable for MI- Cards as part of DLM.
TODO: Wrap this in a env variable
Motivation and Context
Fixes accuracy issue seen when testing with our parity gelu parity tests in DLM.