-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force hipify to use copied version from rocm-6.3.0-14776 build #69
Force hipify to use copied version from rocm-6.3.0-14776 build #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be merged upstream? Would the path for hipify-perl be appropriate? Seems like you are suggesting it belongs in the root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hipify-perl
should be placed under the same directory of amd_hipify.py
rather than root of the source tree, unless there is really good reason.
This is a temporary solution and we are working on another PR that eliminates onnxruntime/tools/ci_build/amd_hipify.py Line 14 in 2580d93
, which should work for newer hipify-perl |
Done. Just retesting this. and will update once done. |
No it shouldn't for now. The plan is to revert this once the changes for hipify are done here for the ROCm EP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use absolute path. Compute it in your amd_hipify.py
tools/ci_build/amd_hipify.py
Outdated
@@ -205,4 +205,4 @@ def hipify(hipify_perl_path, src_file_path, dst_file_path): | |||
parser.add_argument("src", help="src") | |||
args = parser.parse_args() | |||
|
|||
hipify(args.hipify_perl, args.src, args.output) | |||
hipify("/onnxruntime/tools/ci_build/hipify-perl", args.src, args.output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
hipify(os.path.join(os.path.dirname(__file__), "hipify-perl"), args.src, args.output)
Instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - retested this and works
ad60c03
into
rocm6.3_internal_testing
Description
Copied out hipifiy-perl from working docker container as mentioned by @xinyazhang
Retargeted amd_hipify to use the copied item found in onnxruntime root
Motivation and Context
Changed as an upstream change to the rocm stack requires a bunch of work required to get a working rebuild of ROCm EP.
Currently this inhibits development and blocks 6.3 wheel builds