Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSCCLPP] Use boost/filesystem on SLES15 #1507

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nileshnegi
Copy link
Collaborator

Details

Work item:
Internal

What were the changes?
Use boost/filesystem instead of C++ 17 filesystem in MSCCLPP on SLES 15.

Why were the changes made?
SLES 15.5 does not support C++ 17, so we cannot use filesystem methods. As an alternative, boost/filesystem can be used, but some modifications to MSCCLPP src are required.

How was the outcome achieved?
Apply sles-cpp-filesystem.patch to MSCCLPP src if CMake determines that the OS is SLES.

Approval Checklist

Do not approve until these items are satisfied.

  • Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant