Silence SerilaizeToHsaco warning for now

ROCm · May 8, 2024 · 32f20a7 · 32f20a7
1 parent f3b6fd7
commit 32f20a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/external/llvm-project/mlir/include/mlir/Dialect/GPU/Transforms/Passes.h b/external/llvm-project/mlir/include/mlir/Dialect/GPU/Transforms/Passes.h
@@ -151,14 +151,15 @@ class SerializeToBlobPass : public OperationPass<gpu::GPUModuleOp> {
 // Registration
 //===----------------------------------------------------------------------===//
 
+// Remove deprecation warnings because we're going to Get Around To This
 /// Register pass to serialize GPU kernel functions to a HSAco binary
 /// annotation.
-LLVM_DEPRECATED("use Target attributes instead", "")
+// LLVM_DEPRECATED("use Target attributes instead", "")
 void registerGpuSerializeToHsacoPass();
 
 /// Create an instance of the GPU kernel function to HSAco binary serialization
 /// pass.
-LLVM_DEPRECATED("use Target attributes instead", "")
+// LLVM_DEPRECATED("use Target attributes instead", "")
 std::unique_ptr<Pass> createGpuSerializeToHsacoPass(StringRef triple,
                                                     StringRef arch,
                                                     StringRef features,

diff --git a/external/llvm-project/mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp b/external/llvm-project/mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp
@@ -240,9 +240,9 @@ SerializeToHsacoPass::translateToLLVMIR(llvm::LLVMContext &llvmContext) {
       StringRef funcName = f.getName();
       if ("printf" == funcName)
         needOpenCl = true;
-      if (funcName.startswith("__ockl_"))
+      if (funcName.starts_with("__ockl_"))
         needOckl = true;
-      if (funcName.startswith("__ocml_"))
+      if (funcName.starts_with("__ocml_"))
         needOcml = true;
     }
   }