Skip to content

Commit

Permalink
Removed an out-of-date if-statement (#1509)
Browse files Browse the repository at this point in the history
Note: A general GEMM used to have a different writeback operation
that didn't support atomic add, this hasn't been the case for
quite some time but we forgot to remove the guard. This PR
removes the out-of-date guard.
  • Loading branch information
ravil-mobile authored May 9, 2024
1 parent 75f6339 commit 6361349
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions mlir/lib/Dialect/Rock/IR/RockDialect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -798,12 +798,6 @@ LogicalResult GemmOp::verify() {
}
}

if (getStoreMethod() != StoreMethod::Set && !isXdlops && !isWmma) {
const bool isSupportedOutputType = outElems.isF32() || outElems.isF16();
if (!isSupportedOutputType)
return emitOpError("general kernels don't support non-set store methods");
}

if (getDerivedBlockSize().has_value() && !isXdlops && !isWmma) {
return emitOpError(
"general gemm kernels shouldn't have derived block size.");
Expand Down

0 comments on commit 6361349

Please sign in to comment.