Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate quick-tuning lists by conv and gemm #1675

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

djramic
Copy link
Contributor

@djramic djramic commented Oct 9, 2024

This commit separates the quick-tuning lists by conv and gemm operations. We are doing this to reduce the number of configs for quick-tuning, and consequently, the tuning time.
Currently, it is implemented only for xdl-ops. If we agree that it make sense to proceed with this approach I will add it for WMMA as well.

closes : https://github.com/ROCm/rocMLIR-internal/issues/1641

@djramic djramic requested review from jerryyin and sjw36 as code owners October 9, 2024 14:13
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perf drop is too steep.

As we discussed offline, we need anwsers to following :

  1. Why 20 configs ?
  2. If 20 configs, why did we decide to drop what we have dropped here?

I d propose following steps :

  1. Lets find a number between 20 - 40 that does not result in a perf drop.
  2. In the absence of better understanding what Ethan's scripts are doing, we should at least brute force dropping one perf config at a time from the above 40 (or less) configs and decide on dropping of which configs can do the least damage. If we can do this, then we can sort them based on this order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants