Use convert-to-llvm pass for conversions to LLVMIR Dialect #1679
Conversation
…om attached target during lowering
external/llvm-project/mlir/lib/Conversion/ConvertToLLVM/ConvertToLLVMPass.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Re the utility function I was considering, now that I've looked at the structure of the code, I'm seeing another approach, one which'll make ConvertToLLVM less special.
Specifically, take that addTypeAttributeConversion() call and move it into the constructor for LLVMTypeConverter ... and have it take the Attribute -> uint32_t map as an element of LowerToLLVMOptions .
(While doing that, I'd go ahead and extend the DataLayout class with a getEntries() sort of iterator so you can loop through all the entries in that cache)
That way, anyone constructing their LowerToLLVMOptions() with a DataLayoutAnalysis automatically gets this functionality.
| auto typeConverter = std::make_shared<LLVMTypeConverter>(context, options); | ||
|
|
||
| DenseMap<Attribute, uint64_t> addressSpaceMap; | ||
| if (DataLayoutOpInterface iface = dyn_cast<DataLayoutOpInterface>(op)) { |
There was a problem hiding this comment.
I think this is another usage of getAtOrAbove()
There was a problem hiding this comment.
... no, it isn't, but it could be, if DataLayout (the class) grew a method.
umangyadav
force-pushed
the
target_attr
branch
from
efd63a4 to
c966d3b
Compare
This is more of a refactor and WIP. Would require some discussions with upstream.
Depends on #1666
cc: @fabianmcg