Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message to ROCMConfig #237

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Add deprecation message to ROCMConfig #237

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5d6147
Add deprecation message to ROCMConfig
lawruble13 Oct 24, 2024
ba7fbae
Remove trailing whitespace
lawruble13 Nov 21, 2024
87c9dc9
Fix tests to ensure find_package(ROCM) emits a deprecation warning
lawruble13 Nov 21, 2024
948a41a
Update copyright dates
lawruble13 Nov 21, 2024
950079f
Merge branch 'develop' into lwrubles/deprecation
lawruble13 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions share/rocm/cmake/ROCMConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ get_filename_component(_new_rocmcmakebuildtools_path_linux "${_new_rocmcmakebuil

include(CMakeFindDependencyMacro)

message(DEPRECATION
"Use of find_package(ROCM) is deprecated as of ROCm 6.4. Please use find_package(ROCmCMakeBuildTools)")

find_dependency(
ROCmCMakeBuildTools
HINTS
Expand Down
9 changes: 9 additions & 0 deletions test/fail/rename-compatibility.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# ######################################################################################################################
# Copyright (C) 2023 Advanced Micro Devices, Inc.
lawruble13 marked this conversation as resolved.
Show resolved Hide resolved
# ######################################################################################################################

install_dir(${TEST_DIR}/libsimplecompat TARGETS package)
test_check_package(
NAME simple
HEADER simple.h
TARGET simple)
2 changes: 1 addition & 1 deletion test/pass/rename-compatibility.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (C) 2023 Advanced Micro Devices, Inc.
# ######################################################################################################################

install_dir(${TEST_DIR}/libsimplecompat TARGETS package)
install_dir(${TEST_DIR}/libsimplecompat TARGETS package CMAKE_ARGS -Wno-deprecated)
test_check_package(
NAME simple
HEADER simple.h
Expand Down
Loading