Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync staging with mainline #524

Merged
merged 34 commits into from
Jan 2, 2025
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
7821707
External CI: rename pipeline to rocprofiler-compute (#463)
danielsu-amd Nov 5, 2024
9966e4a
Update webui branding (#459)
xuchen-amd Nov 6, 2024
2267075
Update branding in documentation (#442)
peterjunpark Nov 6, 2024
e4241a9
MI300 roofline enablement in rocprofiler-compute (#470)
cfallows-amd Nov 7, 2024
1e5cb38
Update Python format checker (#471)
coleramos425 Nov 7, 2024
e486423
Bump cryptography from 43.0.0 to 43.0.1 in /docs/sphinx (#473)
dependabot[bot] Nov 14, 2024
da5a222
Fix file permission on MI300 roofline binary (#477)
dgaliffiAMD Nov 14, 2024
b0225ca
Removing numpy requirements of <2 (#478)
cfallows-amd Nov 14, 2024
3f90e7a
Fix crash when loading web UI roofline for gfx942 (#479)
benrichard-amd Nov 19, 2024
980a5d4
Rebranding name change patch (#469)
xuchen-amd Nov 25, 2024
2e7e84c
Move dependabot.yml to .github/ and bump rocm-docs-core (#481)
peterjunpark Nov 26, 2024
c6a0c23
Fix packaging for upgrading (#486)
dgaliffiAMD Nov 26, 2024
1bc0c8d
Renamed extension path from omniperf to rocprofiler_compute (#487)
tcgu-amd Nov 26, 2024
c90b6a4
MI300 rhel and sles roofline binaries (#480)
cfallows-amd Nov 26, 2024
903241a
Modify test_profile_general.py ctest to include MI300 enablement (#498)
cfallows-amd Dec 2, 2024
6c470ce
part 1 to support rocprofv3 (#492)
ywang103-amd Dec 4, 2024
9f45c18
fix for crash of timestamp of part 1 for rocprofv3 (#499)
ywang103-amd Dec 4, 2024
3d2c173
quick fix for gfx906 roofline (#505)
feizheng10 Dec 11, 2024
7964f09
Multi node support (#503)
feizheng10 Dec 11, 2024
bb84e35
[CTest] Pipeline failures for MI300 (#483)
coleramos425 Dec 11, 2024
df24dfa
Spatial-multiplexing: part 1 profiling stage (#465)
ywang103-amd Dec 12, 2024
940844e
Simple fix for gpu model value. (#508)
xuchen-amd Dec 13, 2024
ea269a0
Add FP64 to plot adhering to pdf name (#507)
cfallows-amd Dec 16, 2024
edb19f6
Add gpu series for roofline (#510)
xuchen-amd Dec 16, 2024
a83cc73
Fix TCC on MI200 when introduce rocprofv3 (#509)
feizheng10 Dec 16, 2024
f72d70b
Bump rocm-docs-core from 1.9.0 to 1.12.0 in /docs/sphinx (#511)
dependabot[bot] Dec 17, 2024
f3d8e13
Update sample roofline plot img (#516)
peterjunpark Dec 17, 2024
b2ee53f
Modify path to use gpu_model instead of gpu_series to match other wor…
cfallows-amd Dec 17, 2024
6be1a17
Improve formatting when displaying rocprof command. (#476)
xuchen-amd Dec 18, 2024
8172bd8
quick fix for mpi_support (#518)
feizheng10 Dec 20, 2024
3d02560
Pass accumulate counters to rocprofv3 using -E option (#522)
benrichard-amd Dec 23, 2024
ea7d663
Unify all file handling with pathlib (#512)
vedithal-amd Dec 23, 2024
4c722b7
Auto sync staging and mainline on a weekly cadence (#517)
coleramos425 Jan 2, 2025
f34fdc6
Resolve merge conflict, choosing updated project name
coleramos425 Jan 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add gpu series for roofline (#510)
* Add gpu_series for roofline.

* Use gpu_series in path names for roofline.
xuchen-amd authored Dec 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit edb19f6313b365d16327b49d971cc6984f13267a
3 changes: 3 additions & 0 deletions src/rocprof_compute_soc/soc_base.py
Original file line number Diff line number Diff line change
@@ -177,6 +177,9 @@ def populate_mspec(self):
self._mspec.cur_sclk = self._mspec.max_sclk
self._mspec.cur_mclk = self._mspec.max_mclk

self._mspec.gpu_series = list(SUPPORTED_ARCHS[self._mspec.gpu_arch].keys())[
0
].upper()
# specify gpu name for gfx942 hardware
self._mspec.gpu_model = list(SUPPORTED_ARCHS[self._mspec.gpu_arch].keys())[
0
2 changes: 1 addition & 1 deletion src/roofline.py
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ def roof_setup(self):
self.__run_parameters["workload_dir"] = os.path.join(
self.__run_parameters["workload_dir"],
self.__args.name,
self.__mspec.gpu_model,
self.__mspec.gpu_series,
)
# create new directory for roofline if it doesn't exist
if not os.path.isdir(self.__run_parameters["workload_dir"]):
2 changes: 1 addition & 1 deletion src/utils/roofline_calc.py
Original file line number Diff line number Diff line change
@@ -336,7 +336,7 @@ def calc_ai(mspec, sort_type, ret_df):
)
pass
try:
if mspec.gpu_model == "MI200":
if mspec.gpu_series == "MI200":
hbm_data += (
(df["TCC_EA_RDREQ_32B_sum"][idx] * 32)
+ (
7 changes: 7 additions & 0 deletions src/utils/specs.py
Original file line number Diff line number Diff line change
@@ -337,6 +337,13 @@ class MachineSpecs:
##########################################
## B. SoC Specs
##########################################
gpu_series: str = field(
default=None,
metadata={
"doc": "The series of the accelerators/GPUs in the system.",
"name": "GPU Series",
},
)
gpu_model: str = field(
default=None,
metadata={
2 changes: 1 addition & 1 deletion src/utils/utils.py
Original file line number Diff line number Diff line change
@@ -877,7 +877,7 @@ def mibench(args, mspec):
+ "-"
+ distro_map[target_binary["distro"]]
+ "-"
+ mspec.gpu_model.lower()
+ mspec.gpu_series.lower()
+ "-rocm"
+ target_binary["rocm_ver"]
)