forked from triton-lang/triton
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test and benchmark for explicit dot GEMM #637
Merged
brunomazzottiamd
merged 1 commit into
ROCm:main_perf
from
brunomazzottiamd:271_add_test_and_bench_to_multreduce_matmul
Oct 14, 2024
Merged
Add test and benchmark for explicit dot GEMM #637
brunomazzottiamd
merged 1 commit into
ROCm:main_perf
from
brunomazzottiamd:271_add_test_and_bench_to_multreduce_matmul
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
brunomazzottiamd
force-pushed
the
271_add_test_and_bench_to_multreduce_matmul
branch
2 times, most recently
from
September 24, 2024 14:26
c0c697a
to
f6209e7
Compare
brunomazzottiamd
force-pushed
the
271_add_test_and_bench_to_multreduce_matmul
branch
from
October 1, 2024 14:03
f6209e7
to
14a7e75
Compare
brunomazzottiamd
force-pushed
the
271_add_test_and_bench_to_multreduce_matmul
branch
from
October 2, 2024 12:40
02ddbfd
to
b48012f
Compare
vgokhale
reviewed
Oct 10, 2024
vgokhale
approved these changes
Oct 10, 2024
brunomazzottiamd
force-pushed
the
271_add_test_and_bench_to_multreduce_matmul
branch
from
October 11, 2024 19:31
b48012f
to
0c16e7a
Compare
vgokhale
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
brunomazzottiamd
deleted the
271_add_test_and_bench_to_multreduce_matmul
branch
October 14, 2024 12:46
micmelesse
pushed a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing test and benchmark features to the explicit dot GEMM Triton kernel developed in the scope of https://github.com/ROCm/triton-internal/issues/169. It also adds GEMM implemented with
tl.dot
to the mix so we can easily compare it to PyTorch GEMM and Triton GEMM implemented with explicit dot, both in terms of correctness and performance.Help / How to run
Running the Triton kernel for a single shape
Checking correctness of a single target shape
Checking correctness of all target shapes
Benchmarking all target shapes
Sample benchmark result on MI300X: