[BUGFIX] Llama3.2 fa crash fix #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshtras
approved these changes
Nov 12, 2024
maleksan85
added a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Aleksandr Malyshev <[email protected]> (cherry picked from commit 9a46e97)
maleksan85
added a commit
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Aleksandr Malyshev <[email protected]> (cherry picked from commit 9a46e97)
maleksan85
added a commit
that referenced
this pull request
Nov 19, 2024
Co-authored-by: Aleksandr Malyshev <[email protected]> (cherry picked from commit 9a46e97)
shajrawi
pushed a commit
that referenced
this pull request
Dec 3, 2024
* corrected types for strides in triton FA (#274) (#276) Co-authored-by: Aleksandr Malyshev <[email protected]> (cherry picked from commit 9a46e97) * fused_moe configs for MI325X New fused_moe configs for Mixtral-8x7B and Mixtral-8x22B with TP=1,2,4,8 for both FP8 and FP16 on the recently announced MI325X. --------- Co-authored-by: Aleksandr Malyshev <[email protected]>
gshtras
pushed a commit
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Aleksandr Malyshev <[email protected]> (cherry picked from commit 9a46e97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cross attention case K and V might be non contiguous which was causing int32 overflow and FA kernel to crash. Plus for the case there is no need to trim K and V