Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Navi3 target #327

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Adding Navi3 target #327

merged 1 commit into from
Dec 13, 2024

Conversation

pramenku
Copy link

@pramenku pramenku commented Dec 13, 2024

gfx1030;gfx1100;gfx1101

As per below error, all target as listed below is not working for VLLM and compilation is failing.

http://rocm-ci.amd.com/view/Release-6.3/job/framework-vllm-2.4-ub22-py3.10-ci-rel-6.3/61/console

16:45:04 #27 51.67 -- HIP supported arches: gfx906;gfx908;gfx90a;gfx940;gfx941;gfx942;gfx1030;gfx1100;gfx1101;gfx1200;gfx1201
16:45:11 #27 54.52 CMake Error at CMakeLists.txt:186 (message):
16:45:11 #27 54.52 Target architectures support different types of FP8 formats!

https://ontrack-internal.amd.com/browse/SWDEV-503927

gfx1030;gfx1100;gfx1101
@pramenku pramenku merged commit 9ddae90 into ROCm-6.3 Dec 13, 2024
1 check was pending
@pramenku pramenku deleted the pramenku-patch-1 branch December 13, 2024 12:05
@pramenku
Copy link
Author

After this change, VLLM is compiling fine, http://rocm-ci.amd.com/view/Release-6.3/job/framework-vllm-2.4-ub22-py3.10-ci-rel-6.3/63/console

It's Navi4x, GFX12 ARCH looks not working fully for VLLM.

pramenku added a commit that referenced this pull request Dec 13, 2024
@gshtras
Copy link
Collaborator

gshtras commented Dec 13, 2024

2 issues here
Hard coding the list of architectures
Merging changes to the release branch without any reviews
Please avoid doing that in the future

gshtras added a commit that referenced this pull request Dec 13, 2024
gshtras added a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants