Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rocm get_device name #359

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix rocm get_device name #359

wants to merge 2 commits into from

Conversation

divakar-amd
Copy link

@divakar-amd divakar-amd commented Jan 14, 2025

Problem: Different machines resort to different names. This particularly creates confusion for moe config files.

Using amdsmi api:
product_name for mi308 can result in "MI300X" (see issue-1 below)
market_name seems somewhat better, though not perfect (see issue-2 below)
 
Proposing: use 'market_name' && hard-code names for mi308 & mi300

from amdsmi import *
amdsmi_init()
h = amdsmi_get_processor_handles()[0]
print(amdsmi_get_gpu_asic_info(h))
print(amdsmi_get_gpu_board_info(h))
MI308:
    hjbog2:
        - 'market_name': 'MI308X'
        - 'product_name': 'AMD Instinct MI308X OAM'

    smc300x:
        - 'market_name': 'MI308X'
        - 'product_name': 'AMD Instinct MI300X OAM'  <--- issue-1

    banff-s74:
        - 'market_name': 'AMD Instinct MI308X OAM'  <--- issue-2 | instead of just 'MI308X'
        - 'product_name': 'AMD Instinct MI308X OAM'

MI300:
    s65:
        - 'market_name': 'AMD Instinct MI300X'
        - 'product_name': 'AMD Instinct MI300X OAM'

    s73:
        - 'market_name': 'AMD Instinct MI300X'
        - 'product_name': 'AMD Instinct MI300X OAM'

use 'market_name'
hard-code names for mi308 & mi300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant