Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Hip cmake passthrough #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tvirolai-amd
Copy link

@tvirolai-amd tvirolai-amd commented Jan 15, 2025

vLLM csrc contents are always hipified unless they are .cpp or .cc files. This causes issues when one wants to compile hip files:

If the file is named .cu then hipification either chokes on hip exclusive things or it skips it because there is nothing to hipify, meaning the .hip equivalent is not created and build fails. In addition it is confusing to call the files .cu if they are not actually valid cuda source but hip sources.

If the file is named .hip the compilation breaks due to cyclic dependency as foo.hip depends on foo.hip.

This simple change let's .hip files be excluded from hipifaction process and yet they are compiled with the correct extensions.

This, or a similar change, is needed to introduce hip specific features when compiling for rocm.

@tvirolai-amd tvirolai-amd requested a review from gshtras January 15, 2025 14:23
@gshtras
Copy link
Collaborator

gshtras commented Jan 15, 2025

Please submit this change to the upstream vllm (vllm-project/vllm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants