Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vLLM csrc contents are always hipified unless they are .cpp or .cc files. This causes issues when one wants to compile hip files:
If the file is named .cu then hipification either chokes on hip exclusive things or it skips it because there is nothing to hipify, meaning the .hip equivalent is not created and build fails. In addition it is confusing to call the files .cu if they are not actually valid cuda source but hip sources.
If the file is named .hip the compilation breaks due to cyclic dependency as foo.hip depends on foo.hip.
This simple change let's .hip files be excluded from hipifaction process and yet they are compiled with the correct extensions.
This, or a similar change, is needed to introduce hip specific features when compiling for rocm.