-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] SPU LLVM: Add more clamping, reorder them to be on the result #12185
base: master
Are you sure you want to change the base?
Conversation
cdd4014
to
46abce3
Compare
This PR reintroduces an old issue in Uncharted #4478 |
495f402
to
c3802c2
Compare
I implemented smart float source detection, please retest. |
3b705bb
to
da0f108
Compare
Needs testing with games that are picky with floating point behavior (RDR, LBP2, NCAA) As for performance, I'm not sure it's going to be any better, I've tested this before and I found that clamping inputs was faster since llvm can eliminate the clamping in the case where the inputs are constant or the same value is used across multiple instructions. |
FM can cause this issue if approximation method was removed and only clamping is used. |
I don't know if it also has to do with the Dragon's Crown and Odin Sphere games with 2D side scrolling because of the problem of texture clamping issues with better optimization in the CPU and GPU of the graphics I have no idea if it would eliminate that so that it doesn't get those square errors out.🤔 |
Remove hacks, and reorder clamping where they should be hopefully with better performance. Please test issues that arise when using approx xfloat on master. They can be fixed with this pr in theory.