Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU LLVM: Fix -0 handling in Accurate xfloat mode #12558

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Aug 24, 2022

Resulted incorrectly in -2 instead. Makes the SPU accuracy test results closer to real hardware.

@Nekotekina
Copy link
Member

Why keep sign on -0.0?

@elad335
Copy link
Contributor Author

elad335 commented Aug 26, 2022

For FRDS instruction, seems it keeps the sign for -0. Does x86 produce negative 0 when denormals are disabled?

@elad335 elad335 marked this pull request as draft August 26, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants