Qt: Replace some QApplication::processEvents() and QDialog::exec() #13876
Conversation
|
|
||
| vfs_dialog_usb_input* input_dialog = new vfs_dialog_usb_input(device_name, default_info, &info, m_gui_settings, this); | ||
| if (input_dialog->exec() == QDialog::Accepted) | ||
| vfs_dialog_usb_input* input_dialog = new vfs_dialog_usb_input(device_name, *default_info, info.get(), m_gui_settings, this); |
There was a problem hiding this comment.
this is horrible.
you're passing raw pointers here which are captured inside the dialog.
Either make the constuctor arguments shared or use const refs.
There was a problem hiding this comment.
Their ownership is captured in the lambda below.
There was a problem hiding this comment.
that's still horrible software design.
the code should be consistent in its parts, and if you just look at the tab code it makes no sense at all and will cause some regression in the future.
There was a problem hiding this comment.
Parent events are still executing even from QDialog::exec(), if som code does not currently doesn't abide it then it's a bug.
There was a problem hiding this comment.
You're completely missing the point.
| for (const auto& serial : serials) | ||
| { | ||
| if (pdlg->wasCanceled()) | ||
| BatchActionBySerials(pdlg, serials, tr("%0/%1 custom pad configurations cleared"), |
There was a problem hiding this comment.
I think this is all way too complex and detached from the reading flow.
Just create a (new QFutureWatcher(this)) and connect its resultReady signal to the pdlg::setValue.
Then connect the finish signal to deleteLater of QFutureWatcher and stuff.
This would keep the code contained in this function without too much overhead instead of having one huge complex thing a couple of hundred lines above
Both functions are discouraged by Qt for various reasons, it is of course unrealistic to replace them all.
Didn't test. (yet)